Github Merging

Ask and discuss policy about game conduct and rules.

Moderator: In-Game Head Admins

User avatar
Timonk
 
Joined: Thu Nov 15, 2018 6:27 pm
Byond Username: Timonk

Github Merging

Postby Timonk » Sat Jun 15, 2019 9:00 pm #498667

so, basically, why does oranges keep merging heavily disliked stuff? shouldnt there be something that prevents him from merging (policy wise) without considering what the community wants?
Examples:
https://github.com/tgstation/tgstation/pull/44324
https://github.com/tgstation/tgstation/pull/44530
https://github.com/tgstation/tgstation/pull/42386
all of these were heavily disliked, yet oranges still merged them.

dont get me wrong here, this isnt just oranges, but hes doing most of it.


also a gem i found in my pics, god bless his soul
Image
Aw man
So we back in the mine



User avatar
Shaps-cloud
In-Game Game Master
 
Joined: Thu Aug 14, 2014 4:25 am
Byond Username: Shaps

Re: Github Merging

Postby Shaps-cloud » Sat Jun 15, 2019 9:06 pm #498671

DIVISION BETWEEN THE SERVER AND THE CODEBASE IS-
P.S. Shoot Dr. Allen on sight and dissolve his body in acid. Don't burn it.

Image

User avatar
bobbahbrown
 
Joined: Mon Nov 10, 2014 1:04 am
Location: canada
Byond Username: Bobbahbrown

Re: Github Merging

Postby bobbahbrown » Sat Jun 15, 2019 9:06 pm #498672

you answered your own post with a post inside your post.
Image
Image

User avatar
wesoda25
 
Joined: Thu Aug 10, 2017 9:32 pm
Location: Flint, MI
Byond Username: Wesoda25

Re: Github Merging

Postby wesoda25 » Sat Jun 15, 2019 9:12 pm #498674

Probably the most intelligent deitus post I’ve ever seen. But to a degree I feel a “dictator” like codebase is necessary, because the masses really never do seem to know what they actually want. In some select cases its seemed almost antagonistic of the coders to keep certain features, especially when votes have proven they are in the minority. But I suppose thats the price we have to pay for the stability that figures such as oranges bring to SS13.
Spoiler:
ImageImageImageImageImage

User avatar
Timonk
 
Joined: Thu Nov 15, 2018 6:27 pm
Byond Username: Timonk

Re: Github Merging

Postby Timonk » Sat Jun 15, 2019 9:13 pm #498675

bobbahbrown wrote:you answered your own post with a post inside your post.

my point is it shouldn't be like that
Aw man
So we back in the mine

User avatar
Screemonster
 
Joined: Sat Jul 26, 2014 7:23 pm
Byond Username: Scree

Re: Github Merging

Postby Screemonster » Sat Jun 15, 2019 9:14 pm #498676

just because a majority vote agrees on something doesn't make it a good idea

User avatar
Timonk
 
Joined: Thu Nov 15, 2018 6:27 pm
Byond Username: Timonk

Re: Github Merging

Postby Timonk » Sat Jun 15, 2019 9:16 pm #498679

wesoda25 wrote:because the masses really never do seem to know what they actually want


i mean, there is a player poll feature and when was the last time a testmerge got unmerged?
Aw man
So we back in the mine

User avatar
Timonk
 
Joined: Thu Nov 15, 2018 6:27 pm
Byond Username: Timonk

Re: Github Merging

Postby Timonk » Sat Jun 15, 2019 9:17 pm #498680

Screemonster wrote:just because a majority vote agrees on something doesn't make it a good idea

yea, some of this may not seem like a good idea, but that's what the players want, and not for it to be removed.
Aw man
So we back in the mine

User avatar
wesoda25
 
Joined: Thu Aug 10, 2017 9:32 pm
Location: Flint, MI
Byond Username: Wesoda25

Re: Github Merging

Postby wesoda25 » Sat Jun 15, 2019 9:20 pm #498683

Timonk wrote:
wesoda25 wrote:because the masses really never do seem to know what they actually want


i mean, there is a player poll feature and when was the last time a testmerge got unmerged?

It’s usually rare for a feature removal of testmerge stuff bc for it to be testmerged in the first place, coders are usually on board. By the test merge, any flaws coders see are ironed out and its deemed ready for the game. Theres been lots tho im sure, none I could list off the top of my head tho.
Spoiler:
ImageImageImageImageImage

PostThis post was deleted by wesoda25 on Sat Jun 15, 2019 9:28 pm.
Reason: quoted my comment meant to edit oops

User avatar
Arianya
In-Game Game Master
 
Joined: Tue Nov 08, 2016 10:27 am
Byond Username: Arianya

Re: Github Merging

Postby Arianya » Sat Jun 15, 2019 9:39 pm #498695

This isn't for Policy Discussions - the administration (including the headmins) have no greater say in what gets merged then the average player does.

If you're interested in asking oranges about his rationale I suggest posting in the coding subforum - Coding or Feedback, probably.
Frequently playing as Aria Bollet on Bagil & Scary Terry

Source of avatar is here: https://i.imgur.com/hEkADo6.jpg

User avatar
PKPenguin321
In-Game Game Master
 
Joined: Tue Jul 01, 2014 7:02 pm
Location: U S A, U S A, U S A
Byond Username: PKPenguin321
Github Username: PKPenguin321

Re: Github Merging

Postby PKPenguin321 » Sun Jun 16, 2019 12:18 am #498741

Arianya wrote:This isn't for Policy Discussions - the administration (including the headmins) have no greater say in what gets merged then the average player does.

If you're interested in asking oranges about his rationale I suggest posting in the coding subforum - Coding or Feedback, probably.

Not sure why you locked this thread after this post. I believe the suggestion is to reform the current system into a policy that the server has some say over, which is a valid point of discussion in here, like it or not.

A "democratic" pull request process is absolutely something that could hypothetically be put in place as a policy.
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well
tell the best admin how good he is
Spoiler:
Image

SpaceManiac
Code Maintainer
 
Joined: Fri Sep 22, 2017 4:06 am
Byond Username: SpaceManiac
Github Username: SpaceManiac

Re: Github Merging

Postby SpaceManiac » Sun Jun 16, 2019 12:31 am #498745

Game design is not and should not be a popularity contest

User avatar
Arianya
In-Game Game Master
 
Joined: Tue Nov 08, 2016 10:27 am
Byond Username: Arianya

Re: Github Merging

Postby Arianya » Sun Jun 16, 2019 12:39 am #498749

PKPenguin321 wrote:
Arianya wrote:This isn't for Policy Discussions - the administration (including the headmins) have no greater say in what gets merged then the average player does.

If you're interested in asking oranges about his rationale I suggest posting in the coding subforum - Coding or Feedback, probably.

Not sure why you locked this thread after this post. I believe the suggestion is to reform the current system into a policy that the server has some say over, which is a valid point of discussion in here, like it or not.

A "democratic" pull request process is absolutely something that could hypothetically be put in place as a policy.


That's incredibly wild hypothetical on your part - realistically one that could only be implemented by fork of the codebase or the codebase ceding to it. Regardless, this thread is in violation of the Policy Discussion rules:

4.) This board is for discussing in-game administrative policy and rules, including in-game server configuration; coding policies and rules is discussed in #coderbus viewtopic.php?f=2&t=150
Frequently playing as Aria Bollet on Bagil & Scary Terry

Source of avatar is here: https://i.imgur.com/hEkADo6.jpg

User avatar
cedarbridge
In-Game Admin
 
Joined: Fri May 23, 2014 12:24 am
Byond Username: Cedarbridge

Re: Github Merging

Postby cedarbridge » Sun Jun 16, 2019 12:40 am #498750

SpaceManiac wrote:Game design is not and should not be a popularity contest

Strong agree. Its good that players are interested in the state of the game and its development direction. They should actively share how they feel about changes and make/suggest some. But many necessary changes would not currently exist if every change were subject to even more political games and hand wringing. Getting to vote about changes feels good for the randoms that cast votes, but merely playing the game does not grant special insight into how the game functions nor does it provide a stable field on which the game can be developed.

This also opens the door to code changes by coders people like for reasons other than their code gaining more support for their changes not because they are good changes, but because the coder is popular or charismatic and pulls more people to upvote their code.

Keep democratic memes out of the codebase

User avatar
Jimmius
In-Game Admin
 
Joined: Wed Dec 19, 2018 11:00 pm
Byond Username: Jimmius

Re: Github Merging

Postby Jimmius » Sun Jun 16, 2019 12:49 am #498755

yeah let's do a global player poll on every server for every PR before it gets merged, even minor bugfixes, there are no downsides to this at all
unless you're saying a pr being merged or not should be decided by the upvotes and downvotes it gets on github, which is even funnier honestly

User avatar
PKPenguin321
In-Game Game Master
 
Joined: Tue Jul 01, 2014 7:02 pm
Location: U S A, U S A, U S A
Byond Username: PKPenguin321
Github Username: PKPenguin321

Re: Github Merging

Postby PKPenguin321 » Sun Jun 16, 2019 1:03 am #498758

Arianya wrote:
4.) This board is for discussing in-game administrative policy and rules, including in-game server configuration; coding policies and rules is discussed in #coderbus viewtopic.php?f=2&t=150

Going to say that this is superseded by the act of proposing new policy, which I explicitly allowed in the board guidlines (see viewtopic.php?f=33&t=11057)
Normally coding changes would be moved out, yes, but this thread is specifically about proposing a new server policy that handles how we interact with code.
Whether what's proposed in this thread is a good idea or not should be discussed, and whether it should be locked and resolved is up to headmins (or on rare occasion a moderator if the thread goes wildly out of hand), not you.
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well
tell the best admin how good he is
Spoiler:
Image

User avatar
wesoda25
 
Joined: Thu Aug 10, 2017 9:32 pm
Location: Flint, MI
Byond Username: Wesoda25

Re: Github Merging

Postby wesoda25 » Sun Jun 16, 2019 2:21 am #498775

I think a system where if a feature is controversial enough, and its put to vote in game and say X% of active players vote X% majority, coders have to honor the polls decision. This way only truly horrific features which are universally hated can be put up for removal, a check of sorts.

The “teehee every bugfix vote” is idiotic and we know it. What I proposed obviously wouldn’t be a perfect system, nor should it be the finished product, but would giving the players some sort of insurance against the will of coders.
Spoiler:
ImageImageImageImageImage

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Location: Think about something witty and pretend I put it here
Byond Username: Shadowflame909

Re: Github Merging

Postby Shadowflame909 » Sun Jun 16, 2019 2:52 am #498784

cedarbridge wrote:
SpaceManiac wrote:Game design is not and should not be a popularity contest

Strong agree. Its good that players are interested in the state of the game and its development direction. They should actively share how they feel about changes and make/suggest some. But many necessary changes would not currently exist if every change were subject to even more political games and hand wringing. Getting to vote about changes feels good for the randoms that cast votes, but merely playing the game does not grant special insight into how the game functions nor does it provide a stable field on which the game can be developed.

This also opens the door to code changes by coders people like for reasons other than their code gaining more support for their changes not because they are good changes, but because the coder is popular or charismatic and pulls more people to upvote their code.

Keep democratic memes out of the codebase


I would agree if maintainers actually gave a damn about quality control.

So many controversial obviously bug filled Prs getting merged.

We need a little bit more than just the bare minimum that is instantly closing the obvious meme PRs.

Coders should be forced to fix the issues in their ideas if they want it merged. A half-baked idea only harms the people that actually play the game.

Tsk tsk tsk.
Image
Spoiler:
ThanatosRa wrote:My biggest problem is that I can't fix any of this.


Boris wrote:shadowflame either has a brain the size of a pea or one the size of the moon and he's playing 58D chess.


BeeSting12 wrote:please write an apology to this forums, this community, the host, and the internet as a whole for the data storage space you wasted with this complaint.


BebeYoshi wrote:Saltyflame909


Cobby wrote:The trash bin... have you lost your way home anon?

User avatar
cedarbridge
In-Game Admin
 
Joined: Fri May 23, 2014 12:24 am
Byond Username: Cedarbridge

Re: Github Merging

Postby cedarbridge » Sun Jun 16, 2019 3:54 am #498797

Exactly which part of "give a bunch of non-coders a vote on what counts for good code" suddenly makes the code better? You don't make the NBA better by having the fans in the bleachers write the rules.

User avatar
wesoda25
 
Joined: Thu Aug 10, 2017 9:32 pm
Location: Flint, MI
Byond Username: Wesoda25

Re: Github Merging

Postby wesoda25 » Sun Jun 16, 2019 3:56 am #498798

cedarbridge wrote:Exactly which part of "give a bunch of non-coders a vote on what counts for good code" suddenly makes the code better? You don't make the NBA better by having the fans in the bleachers write the rules.

Fans of the NBA don’t play the game.
Spoiler:
ImageImageImageImageImage

User avatar
cedarbridge
In-Game Admin
 
Joined: Fri May 23, 2014 12:24 am
Byond Username: Cedarbridge

Re: Github Merging

Postby cedarbridge » Sun Jun 16, 2019 4:02 am #498799

wesoda25 wrote:
cedarbridge wrote:Exactly which part of "give a bunch of non-coders a vote on what counts for good code" suddenly makes the code better? You don't make the NBA better by having the fans in the bleachers write the rules.

Fans of the NBA don’t play the game.

You're right. They pay for the tickets and attend the game. You log onto a server running the codebase's code. They play the game you want a hand in: the code.

User avatar
Timonk
 
Joined: Thu Nov 15, 2018 6:27 pm
Byond Username: Timonk

Re: Github Merging

Postby Timonk » Sun Jun 16, 2019 6:05 am #498813

Jimmius wrote:yeah let's do a global player poll on every server for every PR before it gets merged, even minor bugfixes, there are no downsides to this at all
unless you're saying a pr being merged or not should be decided by the upvotes and downvotes it gets on github, which is even funnier honestly

Maybe a mix of that? Make a player poll for controversial PRs?
Aw man
So we back in the mine

User avatar
Timonk
 
Joined: Thu Nov 15, 2018 6:27 pm
Byond Username: Timonk

Re: Github Merging

Postby Timonk » Sun Jun 16, 2019 6:08 am #498814

cedarbridge wrote:
wesoda25 wrote:
cedarbridge wrote:Exactly which part of "give a bunch of non-coders a vote on what counts for good code" suddenly makes the code better? You don't make the NBA better by having the fans in the bleachers write the rules.

Fans of the NBA don’t play the game.

You're right. They pay for the tickets and attend the game. You log onto a server running the codebase's code. They play the game you want a hand in: the code.

I mean the NBA viewers are basically the audience on YouTube, etc. and we are the basketball players?
Aw man
So we back in the mine

User avatar
cedarbridge
In-Game Admin
 
Joined: Fri May 23, 2014 12:24 am
Byond Username: Cedarbridge

Re: Github Merging

Postby cedarbridge » Sun Jun 16, 2019 6:42 am #498815

Timonk wrote:
cedarbridge wrote:
wesoda25 wrote:
cedarbridge wrote:Exactly which part of "give a bunch of non-coders a vote on what counts for good code" suddenly makes the code better? You don't make the NBA better by having the fans in the bleachers write the rules.

Fans of the NBA don’t play the game.

You're right. They pay for the tickets and attend the game. You log onto a server running the codebase's code. They play the game you want a hand in: the code.

I mean the NBA viewers are basically the audience on YouTube, etc. and we are the basketball players?

How on Earth did you come to such a terrible conclusion?

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Location: Think about something witty and pretend I put it here
Byond Username: Shadowflame909

Re: Github Merging

Postby Shadowflame909 » Sun Jun 16, 2019 6:47 am #498816

Because we play the game while the greedy team owners make terrible business decisions
Image
Spoiler:
ThanatosRa wrote:My biggest problem is that I can't fix any of this.


Boris wrote:shadowflame either has a brain the size of a pea or one the size of the moon and he's playing 58D chess.


BeeSting12 wrote:please write an apology to this forums, this community, the host, and the internet as a whole for the data storage space you wasted with this complaint.


BebeYoshi wrote:Saltyflame909


Cobby wrote:The trash bin... have you lost your way home anon?

SpaceManiac
Code Maintainer
 
Joined: Fri Sep 22, 2017 4:06 am
Byond Username: SpaceManiac
Github Username: SpaceManiac

Re: Github Merging

Postby SpaceManiac » Sun Jun 16, 2019 7:00 am #498818

This basketball analogy is clearly too confusing, if it's so easy to equate "playing spacemans" with "playing pro basketball" just because they're both called "playing".

Coding involves work. The best way to influence the direction of the codebase is to put in that work.

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Location: Think about something witty and pretend I put it here
Byond Username: Shadowflame909

Re: Github Merging

Postby Shadowflame909 » Sun Jun 16, 2019 7:15 am #498820

I'm sick of all the work being half-assed and being accepted.

Because ultimately it harms the player.

The player is sick of being abused! aaaaa
Image
Spoiler:
ThanatosRa wrote:My biggest problem is that I can't fix any of this.


Boris wrote:shadowflame either has a brain the size of a pea or one the size of the moon and he's playing 58D chess.


BeeSting12 wrote:please write an apology to this forums, this community, the host, and the internet as a whole for the data storage space you wasted with this complaint.


BebeYoshi wrote:Saltyflame909


Cobby wrote:The trash bin... have you lost your way home anon?

User avatar
NoxVS
 
Joined: Sun Apr 22, 2018 7:43 pm
Location: Maintenance
Byond Username: NoxVS

Re: Github Merging

Postby NoxVS » Sun Jun 16, 2019 8:10 am #498822

I can’t really think of a better system than what we have here. While there are some moments that I think democracy would be better, there are also moments where something is changed for the better despite all people wanting otherwise separated chemicals
Image

User avatar
Steelpoint
Github User
 
Joined: Thu Apr 17, 2014 6:37 pm
Location: The Armoury
Byond Username: Steelpoint
Github Username: Steelpoint

Re: Github Merging

Postby Steelpoint » Sun Jun 16, 2019 11:03 am #498828

Outside the scope of this, but I always thought there was a 24 hour rule to merging new pull requests?

Realistically, and on topic, nothing will change.
Image

User avatar
cedarbridge
In-Game Admin
 
Joined: Fri May 23, 2014 12:24 am
Byond Username: Cedarbridge

Re: Github Merging

Postby cedarbridge » Sun Jun 16, 2019 4:30 pm #498842

SpaceManiac wrote:This basketball analogy is clearly too confusing, if it's so easy to equate "playing spacemans" with "playing pro basketball" just because they're both called "playing".

Coding involves work. The best way to influence the direction of the codebase is to put in that work.

I'm guessing that's the only way that metaphor got confused. "I consume the thing so I'm best suited to dictate how the thing is made" makes no sense in either of those cases.

Shadowflame909 wrote:Because we play the game while the greedy team owners make terrible business decisions


Entitlement without actual entitlement.

User avatar
Dax Dupont
In-Game Admin
 
Joined: Sun Apr 20, 2014 9:07 pm
Location: Belgium
Byond Username: DaxYeen
Github Username: DaxDupont

Re: Github Merging

Postby Dax Dupont » Sun Jun 16, 2019 5:01 pm #498845

bring back kor

User avatar
Qbmax32
In-Game Admin
 
Joined: Sun Feb 19, 2017 4:05 am
Location: somewhere
Byond Username: Qbmax32
Github Username: qbmax32

Re: Github Merging

Postby Qbmax32 » Sun Jun 16, 2019 5:48 pm #498847

return the slime to us
my admin feedback thread


epic gamer quote compilation
Spoiler:
datorangebottle wrote:what, not having to act like customer service in a volunteer customer service position?

Here's a rebuttal: you're literally in a customer service slash celebrity position. Volunteer or not.

Malkraz wrote:can you stop posting this shit

Nalzul wrote:Fuck Blob (can you imagine how hot it would be to be gangbanged by a bunch of blobbernauts, the blob, and spores)

Wyzack wrote:qbmax your pathetic display of abhorrent burgercraft has brought shame onto the omnivores

Plapatin wrote:i AM the senate

BONERMASTER wrote:I am a big thinker, and it would only be logical if my character had a big head as well. And glasses. Because only people that think, wear glasses.

feem wrote:i tried to send canisters of urine to the station but ended up turning all oxygen into urine and breaking lavaland and also breathing

Anonmare wrote:Each post in this thread can't settle on what it wants to be, but yet, each one is more cursed than the last.

Beesting12 wrote:please write an apology to this forums, this community, the host, and the internet as a whole for the data storage space you wasted with this complaint.

Vile Beggar wrote:i don't like this thread

imsxz wrote:nervore

FantasticFwoosh wrote:I will whisper sweet nothings that will confuse and perhaps scare you a little, but enhance the experience no-less.

afelinidisfinetoo wrote:By the way, the person who posted that catgirl porn on the github page was me. If anyone wants my private stash just PM me

Nervere wrote:Anything for a femoid.....

Qbopper wrote:I'm a dumb poopy butthead

CitrusGender wrote:god i love it when people feed me my own fried legs

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Location: Think about something witty and pretend I put it here
Byond Username: Shadowflame909

Re: Github Merging

Postby Shadowflame909 » Sun Jun 16, 2019 6:26 pm #498851

I actually agreed with pretty much of all of Kors design decisions but I'm still unsure if there was actually a point of time, even in Kor's time. That people actually had any convincing power over the maintainers.

Basically oligarchs now.

Which makes me quite the aggro'd gamer when broken half-baked PRs get merged instead of maintainers forcing lame shitters to fix their own PRs.

I know that even the current maintainers don't give a fuck about the current issue tracker (Some of them do. I guess, otherwise that whole code lock-down thing would have never happened.) But I don't think we should just allow code to break mechanics and gimmicks very noticeably and just wait for someone else to code a fix for it because you like the PR.

That's so lazy and WYCI is going to crash and burn /tg/station with no survivors because with minimal design direction other then "shake up the meta to keep power-gamers on their toes" and "nerf this old feature because players have gotten too reliant on it" you're going to end up in a state of entropy where the game literally is too convoluted to do anything enjoyable anymore.

So yeah, you're going to turn us into paradise maintainers!
Image
Spoiler:
ThanatosRa wrote:My biggest problem is that I can't fix any of this.


Boris wrote:shadowflame either has a brain the size of a pea or one the size of the moon and he's playing 58D chess.


BeeSting12 wrote:please write an apology to this forums, this community, the host, and the internet as a whole for the data storage space you wasted with this complaint.


BebeYoshi wrote:Saltyflame909


Cobby wrote:The trash bin... have you lost your way home anon?

PostThis post was deleted by Timonk on Sun Jun 16, 2019 6:38 pm.
Reason: oops

User avatar
Timonk
 
Joined: Thu Nov 15, 2018 6:27 pm
Byond Username: Timonk

Re: Github Merging

Postby Timonk » Sun Jun 16, 2019 6:39 pm #498854

SpaceManiac wrote:Game design is not and should not be a popularity contest

are you telling me you would merge something that literally nobody wants?
Aw man
So we back in the mine

User avatar
Jimmius
In-Game Admin
 
Joined: Wed Dec 19, 2018 11:00 pm
Byond Username: Jimmius

Re: Github Merging

Postby Jimmius » Sun Jun 16, 2019 6:42 pm #498855

Timonk wrote:
SpaceManiac wrote:Game design is not and should not be a popularity contest

are you telling me you would merge something that literally nobody wants?

hello i wanted all three of the prs in the OP merged

User avatar
IkeTG
 
Joined: Wed Feb 24, 2016 2:03 am
Location: Here, Now
Byond Username: LizardDreams

Re: Github Merging

Postby IkeTG » Sun Jun 16, 2019 7:44 pm #498857

Timonk wrote:yea, some of this may not seem like a good idea, but that's what the players want, and not for it to be removed.

So say this topic inspires new policy and the community gets a greater say in merges. Hypothetically, let's say something unpopular needs to get merged and, in hindsight, that thing will be good for the server. Do you think the community would be able to make the right choice and allow it to be merged?
NSFW:
Image
Spoiler:

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Location: Think about something witty and pretend I put it here
Byond Username: Shadowflame909

Re: Github Merging

Postby Shadowflame909 » Sun Jun 16, 2019 7:55 pm #498859

If it needed to be merged then it wouldn't be unpopular.

Sorry gamer, but the maintaners and the players want a whole different game.
Image
Spoiler:
ThanatosRa wrote:My biggest problem is that I can't fix any of this.


Boris wrote:shadowflame either has a brain the size of a pea or one the size of the moon and he's playing 58D chess.


BeeSting12 wrote:please write an apology to this forums, this community, the host, and the internet as a whole for the data storage space you wasted with this complaint.


BebeYoshi wrote:Saltyflame909


Cobby wrote:The trash bin... have you lost your way home anon?

User avatar
IkeTG
 
Joined: Wed Feb 24, 2016 2:03 am
Location: Here, Now
Byond Username: LizardDreams

Re: Github Merging

Postby IkeTG » Sun Jun 16, 2019 8:11 pm #498864

Shadowflame909 wrote:If it needed to be merged then it wouldn't be unpopular.

Do you believe this will be the case every single time there's an unpopular PR? Why should we trust the community's foresight?
NSFW:
Image
Spoiler:

User avatar
Timonk
 
Joined: Thu Nov 15, 2018 6:27 pm
Byond Username: Timonk

Re: Github Merging

Postby Timonk » Sun Jun 16, 2019 8:24 pm #498867

IkeTG wrote:
Shadowflame909 wrote:If it needed to be merged then it wouldn't be unpopular.

Do you believe this will be the case every single time there's an unpopular PR? Why should we trust the community's foresight?

Do you really think the majority of players wanted seperated chems and null crates removed? Emagging the cargo console is basically useless now unless you want that static weak gamer gear for 5k or so
Aw man
So we back in the mine

User avatar
IkeTG
 
Joined: Wed Feb 24, 2016 2:03 am
Location: Here, Now
Byond Username: LizardDreams

Re: Github Merging

Postby IkeTG » Sun Jun 16, 2019 8:26 pm #498868

Timonk wrote:Do you really think the majority of players wanted seperated chems and null crates removed?

That wasn't my question.
NSFW:
Image
Spoiler:

User avatar
Timonk
 
Joined: Thu Nov 15, 2018 6:27 pm
Byond Username: Timonk

Re: Github Merging

Postby Timonk » Sun Jun 16, 2019 8:31 pm #498869

Kinda answered that first part though
Aw man
So we back in the mine

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Location: Think about something witty and pretend I put it here
Byond Username: Shadowflame909

Re: Github Merging

Postby Shadowflame909 » Sun Jun 16, 2019 8:32 pm #498870

IkeTG wrote:
Shadowflame909 wrote:If it needed to be merged then it wouldn't be unpopular.

Do you believe this will be the case every single time there's an unpopular PR? Why should we trust the community's foresight?


Because I have no reason not to.
Image
Spoiler:
ThanatosRa wrote:My biggest problem is that I can't fix any of this.


Boris wrote:shadowflame either has a brain the size of a pea or one the size of the moon and he's playing 58D chess.


BeeSting12 wrote:please write an apology to this forums, this community, the host, and the internet as a whole for the data storage space you wasted with this complaint.


BebeYoshi wrote:Saltyflame909


Cobby wrote:The trash bin... have you lost your way home anon?

User avatar
IkeTG
 
Joined: Wed Feb 24, 2016 2:03 am
Location: Here, Now
Byond Username: LizardDreams

Re: Github Merging

Postby IkeTG » Sun Jun 16, 2019 8:39 pm #498874

You're arguing that oranges doesn't give a good enough reason why something was merged, but here you are not giving a good enough reason why something shouldn't be merged. How would applying this topic's policy change anything except making a force in the codebase that's way harder to hold accountable?
NSFW:
Image
Spoiler:

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Location: Think about something witty and pretend I put it here
Byond Username: Shadowflame909

Re: Github Merging

Postby Shadowflame909 » Sun Jun 16, 2019 8:50 pm #498878

No, I'm upset that so much broken code gets merged and the maintainers shove it onto other people to fix it. "eventually"

If the bug is obvious, then the coder should fix their own shit before it gets merged. We shouldn't accept the half-baked code.

That's all I'm saying. If the maintainers aren't willing to do so. Then maybe the players would have more interest in the quality of life of /tg/station. Since they're the ones actually dealing with it.
Image
Spoiler:
ThanatosRa wrote:My biggest problem is that I can't fix any of this.


Boris wrote:shadowflame either has a brain the size of a pea or one the size of the moon and he's playing 58D chess.


BeeSting12 wrote:please write an apology to this forums, this community, the host, and the internet as a whole for the data storage space you wasted with this complaint.


BebeYoshi wrote:Saltyflame909


Cobby wrote:The trash bin... have you lost your way home anon?

User avatar
IkeTG
 
Joined: Wed Feb 24, 2016 2:03 am
Location: Here, Now
Byond Username: LizardDreams

Re: Github Merging

Postby IkeTG » Sun Jun 16, 2019 9:13 pm #498882

You're trying to frame the issue of bugs as a matter of laziness or irresponsibility because it's easier to attack those two points. "If the bug is obvious..." If all the bugs are so obvious, why are all the players, who in your eyes are perfectly capable of vetting merges, not fixing them right now?
If you want meaningful change you need to make a good, solid case for the change. Otherwise, you're just beating around the bush and squabbling over what if's.
NSFW:
Image
Spoiler:

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Location: Think about something witty and pretend I put it here
Byond Username: Shadowflame909

Re: Github Merging

Postby Shadowflame909 » Sun Jun 16, 2019 9:21 pm #498883

That's the problem. We have over 1000 bugs that the maintainers seemingly don't care about because of how "wonky" the issue tracker is.

We don't need any PRs adding more of them.

It's a quality of life thing. And maintainers aren't living up to quality control.

The only real aspect of that I've seen is just instantly closing meme PRs as PK Penguin adds in a dildo PR. Or another counter-nerf PR's that happen out of outrage.

I just want more quality control.

Because of the current standard of accepting quirks and issues within a PR only makes the game worse.

Also Hint, if the ever-growing issue logger isn't a sign. Those issues don't get fixed.
Image
Spoiler:
ThanatosRa wrote:My biggest problem is that I can't fix any of this.


Boris wrote:shadowflame either has a brain the size of a pea or one the size of the moon and he's playing 58D chess.


BeeSting12 wrote:please write an apology to this forums, this community, the host, and the internet as a whole for the data storage space you wasted with this complaint.


BebeYoshi wrote:Saltyflame909


Cobby wrote:The trash bin... have you lost your way home anon?

User avatar
IkeTG
 
Joined: Wed Feb 24, 2016 2:03 am
Location: Here, Now
Byond Username: LizardDreams

Re: Github Merging

Postby IkeTG » Sun Jun 16, 2019 9:32 pm #498884

You're saying quality control but you aren't making a visible case as to what you mean by quality control or how you think one could work towards achieving this quality control. This is a good example of why giving players a say in what gets merged would make things more confusing and less efficient, simply because a lot of players would say Thing Bad but couldn't feasibly elaborate on workable solutions or alternatives.
NSFW:
Image
Spoiler:

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: Github Merging

Postby oranges » Sun Jun 16, 2019 9:37 pm #498885

itt people with no understanding of how to run a codebase
Image

Next

Return to Policy Discussion

Who is online

Users browsing this forum: No registered users